[KYUUBI #7407] STGroup free to avoid OOM Kill#7408
Open
oh0873 wants to merge 3 commits intoapache:masterfrom
Open
[KYUUBI #7407] STGroup free to avoid OOM Kill#7408oh0873 wants to merge 3 commits intoapache:masterfrom
oh0873 wants to merge 3 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a heap growth/OOM issue in LDAP authentication by ensuring StringTemplate’s cached compiled templates/tokens don’t accumulate indefinitely.
Changes:
- Instantiate
STwith a per-querySTGroupinstead of the default group. - Unload the
STGroupafter rendering the LDAP search filter to release cached template state.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ication/ldap/Query.scala Spelling Fix Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
pan3793
reviewed
Apr 21, 2026
| this.filterTemplate = new ST(filterTemplate) | ||
| val group = new STGroup() | ||
| this.filterTemplateGroup = Some(group) | ||
| this.filterTemplate = new ST(group, filterTemplate) |
Member
There was a problem hiding this comment.
does cache only happen in filterTemplate.render?
what will happen if we call def filter multi times?
pan3793
reviewed
Apr 21, 2026
| @@ -127,6 +131,8 @@ | |||
| def build: Query = { | |||
| validate() | |||
| val filter: String = createFilter | |||
Member
There was a problem hiding this comment.
could you update the def createFilter to add a () to the signature? because it actually has a side-effect.
pan3793
reviewed
Apr 21, 2026
| require(filterTemplate != null, "filter is required for LDAP search query") | ||
| } | ||
|
|
||
| private def createFilter: String = filterTemplate.render |
Member
There was a problem hiding this comment.
add () for impure function
Suggested change
| private def createFilter(): String = filterTemplate.render() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
When LDAP Authentication is used ST Token is created and saved in the cache, but it is never freed up.
This is causing continuous increase in heap usage, eventually causing out-of-memory for kyuubi server pods.
This changes is added to clear ST Tokens. Also ST Group is added to avoid any race condition during clean up.
How was this patch tested?
This patch was tested in our customer environment. We observed there's no more continuous heap increase after the fix.
Was this patch authored or co-authored using generative AI tooling?
Cursor auto-complete feature was used.